Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Clean up the wasm-builder and release 1.0.8#3858

Merged
bkchr merged 1 commit intomasterfrom
bkchr-wasm-builder-cleanup
Oct 20, 2019
Merged

Clean up the wasm-builder and release 1.0.8#3858
bkchr merged 1 commit intomasterfrom
bkchr-wasm-builder-cleanup

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented Oct 19, 2019

No description provided.

@bkchr bkchr added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Oct 19, 2019
@bkchr bkchr requested a review from kianenigma October 19, 2019 09:02
@bkchr bkchr requested a review from pepyakin as a code owner October 19, 2019 09:02
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

// `RUSTC_BOOTSTRAP` tells a stable compiler to behave like a nightly. So, when this env
// variable is set, we can assume that whatever rust compiler we have, it is a nightly compiler.
// For "more" information, see:
// https://github.com/rust-lang/rust/blob/fa0f7d0080d8e7e9eb20aa9cbf8013f96c81287f/src/libsyntax/feature_gate/check.rs#L891
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line width check is complaining about this line 😓.

@andresilva
Copy link
Contributor

Needs publish for build to pass.

@bkchr bkchr merged commit d1cd01c into master Oct 20, 2019
@bkchr bkchr deleted the bkchr-wasm-builder-cleanup branch October 20, 2019 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants