This repository was archived by the owner on Nov 15, 2023. It is now read-only.
gossip: futures 03 Receiver#3832
Merged
bkchr merged 12 commits intoparitytech:masterfrom Oct 23, 2019
Merged
Conversation
|
It looks like @kigawas signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Demi-Marie
approved these changes
Oct 19, 2019
Contributor
Demi-Marie
left a comment
Demi-Marie
left a comment
There was a problem hiding this comment.
LGTM if the tests pass.
Member
|
Need resolving |
gavofyork
added
A7-looksgoodcantmerge
and removed
A0-please_review
bkchr
suggested changes
Oct 20, 2019
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
kianenigma
reviewed
Oct 21, 2019
| let inner_rx = gossip | ||
| .messages_for(GRANDPA_ENGINE_ID, topic) | ||
| .map(|x| Ok(x)) | ||
| .compat() |
Contributor
There was a problem hiding this comment.
If I have understood correctly, at some point when the call site of gossip.message_for() also returns a compatible future, this can+should be removed. If this is the case, you can mark #[allow(deprecated)] as TODO: #3099 ... or something similar.
Member
There was a problem hiding this comment.
It should not compile anymore, when message for returns a future03 stream. So, we don't need to have any Todo here.
bkchr
reviewed
Oct 21, 2019
bkchr
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3099