This repository was archived by the owner on Nov 15, 2023. It is now read-only.
client: fix comparison of CachedHeaderMetadata in tree_route #3776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
approved these changes
Oct 7, 2019
rphmeier
approved these changes
Oct 7, 2019
andresilva
force-pushed
the
andre/fix-tree-route
branch
from
95f6f4d to
f0a34f7
Compare
rphmeier
added
A8-looksgood
and removed
A0-please_review
This was referenced Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for regression introduced in #3665. The result of
tree_routewould be erroneously computed since it was taking into account theancestorinCachedHeaderMetadatafor the comparison.I removed the
EqandPartialEqfromCachedHeaderMetadatato avoid any similar issues from being introduced, I also added a test that fails without this fix.