This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Improve tests for BABE #3653
Merged
Improve tests for BABE #3653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
the
A3-in_progress
rphmeier
added
A0-please_review
Demi-Marie
approved these changes
Sep 19, 2019
Contributor
Demi-Marie
left a comment
Demi-Marie
left a comment
There was a problem hiding this comment.
The code looks good. That said, I do not fully understand the changes that have been made since I last worked on it.
| /// Produce the "end slot" of the epoch. This is NOT inclusive to the epoch, | ||
| // i.e. the slots covered by the epoch are `self.start_slot .. self.end_slot()`. | ||
| pub fn end_slot(&self) -> SlotNumber { | ||
| self.start_slot + self.duration |
Contributor
There was a problem hiding this comment.
Is there a proof that this cannot overflow?
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.