This repository was archived by the owner on Nov 15, 2023. It is now read-only.
use pdqselect for median_algorithm selection #3636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @expenses signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
1 similar comment
|
It looks like @expenses signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Contributor
Author
|
I ran a simple benchmark comparing getting the median with both |
Contributor
|
Thanks! Mind if I ice this until #3583 is in, since it contains a much larger change-set on BABE that this might conflict with? |
Contributor
Author
|
Of course! |
rphmeier
added
A1-onice
and removed
A0-please_review
andresilva
approved these changes
Sep 20, 2019
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
lgtm. will merge after #3583 (should be soon anyway).
Co-Authored-By: André Silva <[email protected]>
Co-Authored-By: André Silva <[email protected]>
rphmeier
approved these changes
Sep 23, 2019
Contributor
|
Thanks! |
en
pushed a commit
to en/substrate
that referenced
this pull request
Sep 24, 2019
* use pdqselect for median_algorithm selection instead of sorting the whole vec * Make use of pqdselect clearer Co-Authored-By: André Silva <[email protected]> * Make use of pqdselect clearer Co-Authored-By: André Silva <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would resolve #2926, but
median_algorithmisn't currently used. I haven't written a test yet, but I'd like to if it's important enough.