This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Extract RPC definitions from RPC crate. #3502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
A8-looksgood
and removed
A0-please_review
3 tasks
svyatonik
approved these changes
Aug 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the trait definitions of RPC APIs (and the client implementations) are inside the
substrate-rpccrate that also contains server-side implementations.As the consequence the proejcts like
inkorsubxt(see paritytech/subxt#13) need to compile a large chunk of substrate to get the client part.This PR extracts the APIs to a separate
substrate-rpc-apiscrate, which should maintain a minimal set of dependencies (likeprimitives).