This repository was archived by the owner on Nov 15, 2023. It is now read-only.
im-online: use generic crypto #3500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
previously requested changes
Aug 28, 2019
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Looks good, but you need to remove IM_ONLINE here:
substrate/core/rpc/src/author/mod.rs
Line 165 in 3e257e0
kianenigma
reviewed
Aug 28, 2019
kianenigma
reviewed
Aug 28, 2019
kianenigma
reviewed
Aug 28, 2019
bkchr
reviewed
Aug 28, 2019
kianenigma
reviewed
Aug 28, 2019
andresilva
force-pushed
the
andre/im-online-use-generic-crypto
branch
from
a3c3c12 to
b4e1bb1
Compare
Contributor
Author
|
All grumbles have been addressed. |
bkchr
approved these changes
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i'm online module is hardcoded to use sr25519 keys but we have no specific requirement on crypto type. The crypto is now generic and we support ed25519 and sr25519 for the module. Additionally, I also had to change the
authority-discoverymodule to depend onim_onlineand use it's generic public key type.cc @drewstone