slashing aggregator v2 #3137

niklasad1 · 2019-07-17T08:36:03Z

Hey,

This PR is the next attempt to introduce the slashing aggregator "partly"

What does this

It enables the functionality of what to do each severity level instead of specifying strictly based on misbehavior.

It introducing the following:

Slashing module for keeping track of history and slash.
AfterSlashing implementation for Staking
Generic interface ReportSlash, DoSlash and DoReward
RollingWindow Module

By introducing the traits ReportSlash and DoSlash for a generic interface to slash misbehavior(s) with support of a RollingWindow which will keep the last n sessions of misbehaviors. The number of sessions is determined by the misconduct type.

Additionally, the basic Misconducts kinds are pre-defined in the runtime with a window length as input which needs to be initialized by the concrete misconduct such as BabeEquivocation. So, for example, GrandpaEquivocation may need a different window than BabeEquivocation and so on.

However, it is assumed that the window_length and base_severity is static for the concrete misconduct. I have two different macros for them but they are basically the same with different function names because I think it will be easier to use and you might not need both,

See the example use-case below which is probably easier to understand

What is missing

Misbehavior reporting
Misbehavior implementations (such as BabeEquivocation, Unresponsiveness and similar)
macro for ReportSlash (currently very boilerplate-isch)

Example use-case

See test implementation in substrate/srml/staking/src/slash.rs

All misconduct kinds need to be registered at startup and only these kinds are possible to use in the rolling window. Added a simple test for it too.

parity-cla-bot · 2019-07-17T08:36:05Z

It looks like @niklasad1 signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

parity-cla-bot · 2019-07-17T08:36:06Z

It looks like @niklasad1 signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

marcio-diaz · 2019-08-01T08:24:20Z

I see that you added quite a few more things. Is it ready for another round of reviews? something missing?

This commit splits the `DoSlash` trait in two traits: `DoReward` and `DoSlash` The reasons for it, is that we want reward based on the `total slashed amount` but the entire amount doesn't necessarily be rewarded. Some part of the total slashed amount might need to transmitted to some other part such as `treasory`. Thus, instead we return the total slash and `ReportSlashing` has to determine what to do with the total slashed amount. In other words, the concrete misconduct type determines what to do.

niklasad1 · 2019-08-01T18:35:56Z

@marcio-diaz it is close, will probably be reviewable tomorrow

pepyakin

Nit: docs ranting

srml/support/src/traits.rs

pepyakin · 2019-08-02T11:49:45Z

srml/support/src/traits.rs

+/// Trait for representing window length
+pub trait WindowLength<T> {
+	/// Fetch window length
+	fn window_length(&self) -> &T;


fn(&self) -> &T implies that T should live inside of self, but the usage of trait looks like it should be returned by value.

pepyakin · 2019-08-02T11:54:39Z

srml/support/src/traits.rs

+}
+
+/// A generic trait for paying out rewards
+pub trait DoReward<Reporters, Reward> {


This could mention that it is related to slashing. Otherwise it looks like generic rewarding trait. Alternatively, we could rename it to something like "do reward reporters".

gavofyork · 2019-08-03T11:26:48Z

node/runtime/src/impls.rs

+/// Each variant and its data is a seperate kind
+#[derive(Copy, Clone, Eq, Hash, PartialEq, Encode, Decode)]
+#[cfg_attr(feature = "std", derive(Serialize, Deserialize, Debug))]
+pub enum Misbehavior {


This type shouldn't exist.

node/runtime/src/impls.rs

srml/session/src/lib.rs

srml/support/src/traits.rs

gavofyork · 2019-08-03T11:33:55Z

it's looking better, however there's still a structural issue with that fat enum which expects you to manually enumerate all possible offences. instead, just restrict offences to types that implement a trait to an associated type of the configuration trait. the offence trait can include a
const ID: [u8; 16] (to identify it for using as a map key) and const WINDOW_SIZE: u32 as well as a function to determine how much the slash should be fn slash_amount(offender_count: u32, total: u32) -> Self::Balance.

stale

niklasad1 · 2019-08-04T17:01:37Z

Thanks Gav

However, I'm not sure that fn slash_amount(offender_count: u32, balance: u32) -> Self::Balance is what we want because it would require us to have an API to retrieve the entire slashing history for a certain kind (currently handled by slash mod) and ReportSlash would need the concrete type of the slashing victim and its exposure.

Thus, ReportSlash impl would be more complex and I have tried to keep it as simple as possible so far(i.e, just pass data and call some functions)

Well, I can try to implement it and see it how goes...

niklasad1 added 27 commits July 10, 2019 11:36

very ugly draft

aed1467

progress

89f127c

progress

0f153e5

Merge remote-tracking branch 'origin/master' into na-robs-suggest-slash

81169b9

progress

76173fe

add srml-rolling-window

0288d17

nits

47fdfa1

polish

60c3ff1

rolling_window: don't count unregistered kinds

658d785

All misconduct kinds need to be registered at startup and only these kinds are possible to use in the rolling window. Added a simple test for it too.

fix: add all static misbehaviours

b3ae519

nits

148848f

feat: add implementation DoSlash for Staking

bf86c9d

Merge remote-tracking branch 'origin/master' into na-robs-suggest-slash

20e763f

pass window_len instead of static lookup table

9919efc

Merge remote-tracking branch 'origin/master' into na-robs-suggest-slash

0d187a0

simplify code

32fc271

nits

166bc5c

cleanup

032c7ce

impl window_length for Misbehavior type

eaeb6c8

clarify

1ccf201

make ready

b089258

nits

f50f5fc

feat: impl_kind and impl_base_severity macros

b383c4b

Merge remote-tracking branch 'origin/master' into na-robs-suggest-slash

f21f619

clean

2e5519f

Merge remote-tracking branch 'origin/master' into na-robs-suggest-slash

3a8f024

clean

b41e7d8

niklasad1 requested a review from rphmeier July 17, 2019 08:36

niklasad1 force-pushed the na-robs-suggest-slash branch from 28dd5be to fa2f9c1 Compare July 31, 2019 22:22

niklasad1 added 3 commits August 1, 2019 12:29

fix nits

b95f075

add reward tests

28311fa

pepyakin reviewed Aug 2, 2019

View reviewed changes

niklasad1 added 2 commits August 2, 2019 19:48

feat: slash multiple misconducts 100%

e1541bf

Merge remote-tracking branch 'origin/master' into na-robs-suggest-slash

8e3b804

niklasad1 force-pushed the na-robs-suggest-slash branch from 22bb264 to 8e3b804 Compare August 2, 2019 18:02

niklasad1 added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 2, 2019

gavofyork mentioned this pull request Aug 3, 2019

Refactor key management #3296

Merged

8 tasks

gavofyork reviewed Aug 3, 2019

View reviewed changes

node/runtime/src/impls.rs Outdated Show resolved Hide resolved

gavofyork reviewed Aug 3, 2019

View reviewed changes

srml/session/src/lib.rs Show resolved Hide resolved

gavofyork reviewed Aug 3, 2019

View reviewed changes

srml/support/src/traits.rs Outdated Show resolved Hide resolved

gavofyork added A4-gotissues and removed A0-please_review Pull request needs code review. labels Aug 3, 2019

niklasad1 added 4 commits August 4, 2019 18:42

remove enum Misbehavior

18ddb1b

add trait SlashingOffence, rm WindowLength

a50bbb6

rewrite me

ada88ea

Merge remote-tracking branch 'origin/master' into na-robs-suggest-slash

3029e53

niklasad1 closed this Aug 6, 2019

bkchr deleted the na-robs-suggest-slash branch August 6, 2019 17:39

gnunicorn modified the milestones: 2.1, Polkadot Mar 4, 2020

slashing aggregator v2 #3137

slashing aggregator v2 #3137

Uh oh!

Conversation

niklasad1 commented Jul 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this

What is missing

Example use-case

Uh oh!

parity-cla-bot commented Jul 17, 2019

Uh oh!

parity-cla-bot commented Jul 17, 2019

Uh oh!

marcio-diaz commented Aug 1, 2019

Uh oh!

niklasad1 commented Aug 1, 2019

Uh oh!

pepyakin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pepyakin Aug 2, 2019

Choose a reason for hiding this comment

Uh oh!

pepyakin Aug 2, 2019

Choose a reason for hiding this comment

Uh oh!

gavofyork Aug 3, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gavofyork commented Aug 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

niklasad1 commented Aug 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

niklasad1 commented Jul 17, 2019 •

edited

Loading

gavofyork commented Aug 3, 2019 •

edited

Loading

niklasad1 commented Aug 4, 2019 •

edited

Loading