This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Network crate cleanups #3049
Merged
Merged
Network crate cleanups #3049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the tests are not in the way anymore (#3016), we can clean up the API surface of the networking crate.
While the diff is quite large, it can easily be reviewed commit by commit.
Most of the changes are very straight-forward and should be uncontroversial.
In terms of logic, I moved some methods from the
NetworkServiceto theNetworkWorker. This made it possible to remove theArc<Mutex>around the libp2pSwarm.The network crate now only contains three
Arcs and zeroMutexorRwLock, if you exclude theArcs to the various other components of Substrate (eg.Arc<Client>).