Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 7, 2019

Now that the tests are not in the way anymore (#3016), we can clean up the API surface of the networking crate.

While the diff is quite large, it can easily be reviewed commit by commit.
Most of the changes are very straight-forward and should be uncontroversial.

In terms of logic, I moved some methods from the NetworkService to the NetworkWorker. This made it possible to remove the Arc<Mutex> around the libp2p Swarm.

The network crate now only contains three Arcs and zero Mutex or RwLock, if you exclude the Arcs to the various other components of Substrate (eg. Arc<Client>).

@tomaka tomaka added the A0-please_review Pull request needs code review. label Jul 7, 2019
@gavofyork gavofyork merged commit 09086cf into paritytech:master Jul 8, 2019
@tomaka tomaka deleted the cleanup-net-service branch July 8, 2019 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants