This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merge Protocol and ProtocolBehaviour #2962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@tomaka is this in draft? or ready for review? |
Contributor
Author
|
It's ready for review! Just not for merging, as I want to submit another PR to merge first that rewrites the tests. |
twittner
reviewed
Jul 2, 2019
Contributor
twittner
left a comment
twittner
left a comment
There was a problem hiding this comment.
I had a look at this a couple of days ago. The changes seem fine to me. I was unsure though what to do given the draft status and the failing check.
gavofyork
added
A3-in_progress
Contributor
Author
|
Ready to review/merge! |
tomaka
added
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges
ProtocolandProtocolBehaviour.The
Protocolstruct now implementsNetworkBehaviour.The PR is ready, except for the fact that it totally breaks the network tests in an unrecoverable way.
Right now the network tests infrastructure assumes that we have a single channel of communication with the remote, and that
Protocolexposes this in its API. This PR makes this an implementation detail ofProtocol. Because of that, the tests, by design, can't be "just fixed".I'm going to start working on rewriting the
TestNetstruct, after which we will be able to merge this PR on top. I'm opening it now, so that people are aware of upcoming changes.Can be reviewed commit by commit.