This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
marcio-diaz
added
the
A3-in_progress
marcio-diaz
added
A0-please_review
|
The compile errors need to be fixed. |
marcio-diaz
added
the
A3-in_progress
marcio-diaz
force-pushed
the
marcio/save-vote-indices-to-db
branch
from
cc160b2 to
e7ef2d7
Compare
marcio-diaz
changed the title
Member
|
What is the status of this? |
Contributor
Co-Authored-By: Robert Habermeier <rphmeier@gmail.com>
marcio-diaz
changed the title
marcio-diaz
force-pushed
the
marcio/save-vote-indices-to-db
branch
from
757de27 to
bdb4b4a
Compare
marcio-diaz
added
A0-please_review
andresilva
suggested changes
Jul 10, 2019
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
Please rebase this over master.
| @@ -0,0 +1,938 @@ | |||
| // Copyright 2019 Parity Technologies (UK) Ltd. | |||
| rounds.push_back(genesis); | ||
|
|
||
| let voters = voters.current().1.iter().map(|(a, _)| a.clone()).collect(); | ||
| // let voters = voters.current().1.iter().map(|(a, _)| a.clone()).collect(); |
Member
|
What is the status of this? |
Contributor
Author
After a talk with a w3f researcher we realized that is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to save the votes received indicating the moment of voting in order to answer challenge queries.
Related to paritytech/finality-grandpa#10
Depends on: paritytech/finality-grandpa#65