This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
rphmeier
reviewed
Mar 13, 2019
rphmeier
reviewed
Mar 13, 2019
rphmeier
reviewed
Mar 15, 2019
rphmeier
reviewed
Mar 18, 2019
core/network/src/consensus_gossip.rs
Outdated
| } | ||
|
|
||
| /// Filter out departing messages. | ||
| fn should_send_to(&self, _who: NodeIndex, _topic: &H, _data: &[u8]) -> bool { |
Contributor
There was a problem hiding this comment.
a bit unfortunate that we've got to re-decode all messages each time we try to send them out.
In GRANDPA we'll likely do it by topic, so it'll be zero-cost...
rphmeier
reviewed
Mar 21, 2019
rphmeier
added
A8-looksgood
and removed
A0-please_review
2 tasks
andresilva
suggested changes
Mar 25, 2019
Style Co-Authored-By: arkpar <arkady.paronyan@gmail.com>
…into a-neighbour-packet
andresilva
approved these changes
Mar 28, 2019
Contributor
|
This and #2110 should be ready to merge, but let's wait until 1.0 gets cut. We can ship this in 1.1 after we test it properly on the testnets. |
Member
Author
|
Closing in favor of #2110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
substrate_network::gossipmodule no delegates actual gossiping to the validator.