This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Transaction signing payload is hashed first #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
Member
Author
|
CC @jacogr |
Contributor
|
why? ed25519 signing is already hashing these items to the curve |
Contributor
|
also I think this will break some tests where things are signed manually |
jacogr
reviewed
Jan 30, 2019
rphmeier
approved these changes
Jan 31, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Transaction signing payload is hashed first * Fix tests * Rebuild wasm * Fix tests * Only take payload hash when payload.len > 256 bytes. * Fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the encoded items that make up the signing payload, it's the Blake2/256 of the encoded items whenever the payload length is greater than 256 bytes. This keeps the data needed to craft a signature nice and short.