Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix: try_on_runtime_upgrade for Tuple weight summation #14793

Merged

Conversation

liamaharon
Copy link
Contributor

The current implementation never actually increments the cumulative weight.

@liamaharon liamaharon added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Aug 21, 2023
@liamaharon liamaharon requested review from a team August 21, 2023 07:47
@liamaharon liamaharon changed the title fix: try_on_runtime_upgrade tuple weight summation fix: try_on_runtime_upgrade for Tuple weight summation Aug 21, 2023
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@liamaharon
Copy link
Contributor Author

bot merge force

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants