Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[fix docs compiler warnings] Nicks pallet #14668

Merged
merged 3 commits into from
Jul 29, 2023
Merged

[fix docs compiler warnings] Nicks pallet #14668

merged 3 commits into from
Jul 29, 2023

Conversation

sacha-l
Copy link
Contributor

@sacha-l sacha-l commented Jul 28, 2023 •
edited
Loading

This PR fixes the 7 compiler warnings emitted by running RUSTFLAGS="-W missing_docs" cargo check -p pallet-nicks by adding missing documentation throughout the crate.

@sacha-l sacha-l added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). I6-documentation Documentation needs fixing, improving or augmenting. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 28, 2023
@sacha-l sacha-l requested review from a team July 28, 2023 06:56
ggwpez
ggwpez approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again a #![deny(missing_docs)] please 😄

@ggwpez
Copy link
Member

ggwpez commented Jul 29, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit d1d995b into master Jul 29, 2023
@paritytech-processbot paritytech-processbot bot deleted the sl/fix-warnings-nicks branch July 29, 2023 12:48
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gupnik gupnik gupnik approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I6-documentation Documentation needs fixing, improving or augmenting.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sacha-l @ggwpez @gupnik