Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Contracts: Bugfix Wasm prepare check for chain extension #14642

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

xermicus
Copy link
Member

A subtle bug in the boolean predicate for checking against chain extension imports prevents importing the non-prefixed version even if chain extension are enabled.

…on imports prevents importing the non-prefixed version even if chain extension are enabled are enabled

Signed-off-by: Cyrill Leutwiler <[email protected]>
@xermicus xermicus requested a review from athei as a code owner July 26, 2023 09:40
@xermicus xermicus requested a review from a team July 26, 2023 09:40
@xermicus xermicus added I3-bug The node fails to follow expected behavior. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B0-silent Changes should not be mentioned in any release notes labels Jul 26, 2023
Copy link
Contributor

@pgherveou pgherveou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch

@pgherveou
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit bb0af12 into master Jul 26, 2023
@paritytech-processbot paritytech-processbot bot deleted the cl/contracts-prepare-chain-extension branch July 26, 2023 10:25
pgherveou pushed a commit that referenced this pull request Jul 26, 2023
…on imports prevents importing the non-prefixed version even if chain extension are enabled are enabled (#14642)

Signed-off-by: Cyrill Leutwiler <[email protected]>
coderobe pushed a commit that referenced this pull request Jul 27, 2023
…on imports prevents importing the non-prefixed version even if chain extension are enabled are enabled (#14642) (#14643)

Signed-off-by: Cyrill Leutwiler <[email protected]>
Co-authored-by: Cyrill Leutwiler <[email protected]>
athei added a commit to paritytech/substrate-contracts-node that referenced this pull request Aug 6, 2023
Sync with `polkadot-v1.0.0` in order to include
paritytech/substrate#14642.

Fixes #200
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I3-bug The node fails to follow expected behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants