This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Contracts add wasm ink contract in test#14563
Closed
pgherveou wants to merge 6 commits into
Closed
Conversation
|
The CI pipeline was cancelled due to failure one of the required jobs. |
athei
reviewed
Jul 14, 2023
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
pgherveou
added
A0-please_review
juangirini
reviewed
Jul 14, 2023
Comment on lines
+717
to
+719
| let mut debug_message = | ||
| if cfg!(test) { Some(DebugBufferVec::<T>::default()) } else { None }; | ||
|
|
Contributor
There was a problem hiding this comment.
I really don't like having test conditionals in the main code, but if there isn't another way I think it would look cleaner with feature flags
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an Ink! compiled contract to the test suite