Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

construct_runtime: support for expanding the macro code#14379

Merged
paritytech-processbot[bot] merged 5 commits intomasterfrom
mku-expand-construct-runtime
Jun 14, 2023
Merged

construct_runtime: support for expanding the macro code#14379
paritytech-processbot[bot] merged 5 commits intomasterfrom
mku-expand-construct-runtime

Conversation

@michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented Jun 14, 2023

Support for expanding the generated code from construct_runtime macro into the source file which is included. Allows for better macro debugging (error points to the particular line in expanded source files).

Based on: #13573

Setting FRAME_EXPAND environment variable enables feature.

@michalkucharczyk michalkucharczyk added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 14, 2023
@michalkucharczyk michalkucharczyk requested review from a team June 14, 2023 11:00
@michalkucharczyk michalkucharczyk changed the title construct_runtime: support for expanding the macro code construct_runtime: support for expanding the macro code Jun 14, 2023
@michalkucharczyk michalkucharczyk requested a review from a team June 14, 2023 11:15
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@michalkucharczyk
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit fe65adb into master Jun 14, 2023
@paritytech-processbot paritytech-processbot bot deleted the mku-expand-construct-runtime branch June 14, 2023 18:49
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…#14379)

* construct_runtime: support for expanding the macro code

* Update frame/support/procedural/src/construct_runtime/mod.rs

Co-authored-by: Bastian Köcher <[email protected]>

* Update frame/support/procedural/Cargo.toml

Co-authored-by: Bastian Köcher <[email protected]>

* fmt added

* fmt removed

---------

Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants