This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
WIP: soft deprecate genesisconfig #14202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
reviewed
May 23, 2023
| @@ -401,21 +401,21 @@ pub mod pallet { | |||
| } | |||
|
|
|||
| #[pallet::genesis_config] | |||
| pub struct GenesisConfig<T: Config<I>, I: 'static = ()> { | |||
| pub struct RuntimeGenesisConfig<T: Config<I>, I: 'static = ()> { | |||
There was a problem hiding this comment.
This change is wrong. This isn't the runtime level GenesisConfig.
There was a problem hiding this comment.
Oh man, thanks for pointing this out early enough, I was going into a complete wrong direction. I understood the hard way the need for the renaming 😄
|
Replaced by #14210 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✄ -----------------------------------------------------------------------------
Thank you for your Pull Request! 🙏
Before you submit, please check that:
A*for PR status (one required)B*for changelog (one required)C*for release notes (exactly one required)D*for various implications/requirementsFixes #228orRelated #1337.Refer to the contributing guide for details.
After you've read this notice feel free to remove it.
Thank you!
✄ -----------------------------------------------------------------------------