This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Move authorities interface from Core to consensus #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
added
the
A3-in_progress
|
It looks like @DarkEld3r signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
stanislav-tkach
force-pushed
the
stas-1369-move-authorities-from-core
branch
3 times, most recently
from
8896dec to
c0dd7c7
Compare
stanislav-tkach
force-pushed
the
stas-1369-move-authorities-from-core
branch
16 times, most recently
from
e01b9b3 to
3296f8d
Compare
rphmeier
reviewed
Jan 31, 2019
rphmeier
reviewed
Jan 31, 2019
stanislav-tkach
force-pushed
the
stas-1369-move-authorities-from-core
branch
7 times, most recently
from
25edc90 to
1223ae5
Compare
rphmeier
reviewed
Mar 29, 2019
| /// Authorities API. | ||
| pub trait AuthoritiesApi { | ||
| /// Returns the authorities at the given block. | ||
| fn authorities() -> Vec<AuthorityIdFor<Block>>; |
Contributor
There was a problem hiding this comment.
AuthorityIdFor is not likely to stick around that much longer. We probably will need AuthoritiesApi to become generic in the future.
Contributor
Author
There was a problem hiding this comment.
@rphmeier I hope it can be done outside the scope of this pull request?
stanislav-tkach
force-pushed
the
stas-1369-move-authorities-from-core
branch
from
2e8c27a to
db6c584
Compare
stanislav-tkach
force-pushed
the
stas-1369-move-authorities-from-core
branch
from
853bc7f to
a529be1
Compare
stanislav-tkach
force-pushed
the
stas-1369-move-authorities-from-core
branch
from
a529be1 to
d7b95a0
Compare
…itytech/substrate into stas-1369-move-authorities-from-core
…itytech/substrate into stas-1369-move-authorities-from-core
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Move authorities interface from Core to consensus f * notify all caches of block insert + create with up-to-date best_fin * merged authorities_are_cached from light_grandpa_import2 * Add ProvideCache trait * Create helper function for 'get_cache' * Fix some formatting * Bump impl version * Resolve wasm conflicts * Apply review comments * Use try_for_each * Move authorities interface from Core to consensus f * notify all caches of block insert + create with up-to-date best_fin * merged authorities_are_cached from light_grandpa_import2 * Add ProvideCache trait * Create helper function for 'get_cache' * Fix some formatting * Bump impl version * Resolve wasm conflicts * Apply review comments * Use try_for_each * Move authorities interface from Core to consensus f * notify all caches of block insert + create with up-to-date best_fin * merged authorities_are_cached from light_grandpa_import2 * Add ProvideCache trait * Create helper function for 'get_cache' * Fix some formatting * Bump impl version * Resolve wasm conflicts * Apply review comments * Use try_for_each * Increment impl_version * Update lib.rs
liuchengxu
pushed a commit
to liuchengxu/substrate
that referenced
this pull request
May 31, 2023
Add infrastructure support for the core domain testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1365.