-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update reservable docs to reflect actual ed #13894
Update reservable docs to reflect actual ed #13894
Conversation
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Ideally I'd like to see some test cases that exactly demonstrate the reaping semantics, and have them linked to the rustdocs using |
bot fmt |
@gavofyork https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2984175 was started for your command Comment |
@gavofyork Command |
Is currency being completely superseded by fungibles or will it continue to be maintained? |
It's already deprecated #12951 I wouldn't bother much about this. |
I guess it would still be useful in the fungible docs/tests. I'll mention it here paritytech/polkadot-sdk#166 |
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
bot rebase |
Error: Command 'Command { std: cd "/storage/repositories/substrate" && "git" "push" "--porcelain" "naterarmstrong" "patch-1", kill_on_drop: false }' failed with status Some(1); output: error: failed to push some refs to 'https://github.com/naterarmstrong/substrate.git' |
@naterarmstrong could you merge master? |
Update reservable documentation to reflect the actual behavior of small reserved balances. Looking into `frame/balances/src/impl_currency.rs` shows that accounts are not reaped even if the reserved balance is very small.
Rebased on master |
bot merge |
Waiting for commit status. |
Update reservable documentation to reflect the actual behavior of small reserved balances.
Looking into
frame/balances/src/impl_currency.rs
shows that accounts are not reaped even if the reserved balance is very small.I didn't fully look, but it seems that this change is related to #12951.