Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update reservable docs to reflect actual ed #13894

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

naterarmstrong
Copy link
Contributor

@naterarmstrong naterarmstrong commented Apr 12, 2023

Update reservable documentation to reflect the actual behavior of small reserved balances.

Looking into frame/balances/src/impl_currency.rs shows that accounts are not reaped even if the reserved balance is very small.

I didn't fully look, but it seems that this change is related to #12951.

@bkchr bkchr requested review from kianenigma and ggwpez May 3, 2023 20:15
@stale
Copy link

stale bot commented Jun 8, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jun 8, 2023
@ggwpez ggwpez added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jun 13, 2023
@stale stale bot removed the A3-stale label Jun 13, 2023
@kianenigma
Copy link
Contributor

Ideally I'd like to see some test cases that exactly demonstrate the reaping semantics, and have them linked to the rustdocs using docify.

@gavofyork
Copy link
Member

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 13, 2023

@gavofyork https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2984175 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-fc6756d2-4a44-4b30-bc08-79a4492845f4 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech-ci paritytech-ci requested review from a team June 13, 2023 17:44
@command-bot
Copy link

command-bot bot commented Jun 13, 2023

@gavofyork Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2984175 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2984175/artifacts/download.

@liamaharon
Copy link
Contributor

liamaharon commented Jun 13, 2023

Ideally I'd like to see some test cases that exactly demonstrate the reaping semantics, and have them linked to the rustdocs using docify.

Is currency being completely superseded by fungibles or will it continue to be maintained?

@juangirini
Copy link
Contributor

juangirini commented Jun 14, 2023

Ideally I'd like to see some test cases that exactly demonstrate the reaping semantics, and have them linked to the rustdocs using docify.

Is currency being completely superseded by fungibles or will it continue to be maintained?

It's already deprecated #12951 I wouldn't bother much about this.

@liamaharon
Copy link
Contributor

Ideally I'd like to see some test cases that exactly demonstrate the reaping semantics, and have them linked to the rustdocs using docify.

Is currency being completely superseded by fungibles or will it continue to be maintained?

It's already deprecated #12951 I wouldn't bother much about this.

I guess it would still be useful in the fungible docs/tests. I'll mention it here paritytech/polkadot-sdk#166

@juangirini juangirini added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 14, 2023
@gavofyork gavofyork added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jun 18, 2023
@stale
Copy link

stale bot commented Jul 18, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jul 18, 2023
@bkchr
Copy link
Member

bkchr commented Jul 19, 2023

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: cd "/storage/repositories/substrate" && "git" "push" "--porcelain" "naterarmstrong" "patch-1", kill_on_drop: false }' failed with status Some(1); output: error: failed to push some refs to 'https://github.com/naterarmstrong/substrate.git'

@bkchr
Copy link
Member

bkchr commented Jul 19, 2023

@naterarmstrong could you merge master?

@stale stale bot removed the A3-stale label Jul 27, 2023
naterarmstrong and others added 2 commits July 27, 2023 14:16
Update reservable documentation to reflect the actual behavior of small reserved balances.

Looking into `frame/balances/src/impl_currency.rs` shows that accounts are not reaped even if the reserved balance is very small.
@naterarmstrong
Copy link
Contributor Author

Rebased on master

@liamaharon
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants