Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove score_update_worst_case default impl #12043

Closed
ggwpez wants to merge 3 commits into from
Closed

Remove score_update_worst_case default impl #12043

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48239dd
Do not default impl feature gated functions
ggwpez Aug 16, 2022
907708d
Use unimplemented macro instead
ggwpez Aug 16, 2022
fff3100
Remove impl
ggwpez Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frame/election-provider-support/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ pub trait SortedListProvider<AccountId> {
/// in their list position.
#[cfg(feature = "runtime-benchmarks")]
fn score_update_worst_case(_who: &AccountId, _is_increase: bool) -> Self::Score {
Comment thread
ggwpez marked this conversation as resolved.
Outdated
Self::Score::max_value()
unimplemented!();
}

@shawntabrizi shawntabrizi Aug 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unimplemented!();
}

@bkchr bkchr Aug 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm with Shawn here.

@ggwpez ggwpez Aug 17, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

}

Expand Down