This repository was archived by the owner on Nov 15, 2023. It is now read-only.
CheckInherentError can now report when something would be valid#1204
Merged
CheckInherentError can now report when something would be valid#1204
Conversation
bkchr
approved these changes
Dec 4, 2018
bkchr
added
A8-looksgood
and removed
A0-please_review
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Rename Fixed128 to FixedI128. * Bump cargo, merge paritytech#6236 fixes Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables consensus proposers to finish proposing only when
check_inherents(block_with_inherents)returns Ok.In
srml-timestamp, thesetinherent will automatically be set forward to the next valid time, but proposers should not broadcast their block until waiting until a time specified byCheckInherentError::ValidAfterTimestamp.The
check_inherentsgenerated by the macro will choose the highestValidAtTimestampvariant returned by submodules.