This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use primitive-types crate to unify Parity Ethereum primitives#1187
Merged
Conversation
sorpaas
added
the
A3-in_progress
sorpaas
force-pushed
the
sp-primitive-types
branch
from
8f1f08a to
9c64247
Compare
sorpaas
force-pushed
the
sp-primitive-types
branch
from
9c64247 to
ea225e0
Compare
Contributor
|
(i would ice this until post 1.0-beta or Polkadot's PoC-3 because it may conflict in non-trivial ways) |
Member
|
How is |
Contributor
Author
|
@gavofyork I put it in a separate crate (https://github.com/paritytech/parity-common/pull/86/files#diff-0deef092ae541af43ff5f5c8d35b262fR9). In this way, if another crate needs to implement codec support for types not defined here, they can reuse those code. |
sorpaas
removed
the
A3-in_progress
Member
|
@sorpaas happy to revisit this once conflicts are sorted |
sorpaas
added
A3-in_progress
gavofyork
added
A0-please_review
gavofyork
approved these changes
Jan 7, 2019
gguoss
pushed a commit
to chainpool/substrate
that referenced
this pull request
Jan 11, 2019
…tech#1187) * Unify primitive types with parity-ethereum * Update primtive-types patch version * Fix merge issue * Add necessary fixed-hash features * Fix node-primitives compile * Reexport impl_serde::serialize as bytes to avoid path changes
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
…tech#1187) * Unify primitive types with parity-ethereum * Update primtive-types patch version * Fix merge issue * Add necessary fixed-hash features * Fix node-primitives compile * Reexport impl_serde::serialize as bytes to avoid path changes
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openethereum/parity-ethereum#9994
This uses the new
primitive-typescrate to allow common types in Parity Ethereum and Substrate to be shared.primitive-types.