This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove not required DigestItem conversion#11165
Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom Apr 4, 2022
Merged
Remove not required DigestItem conversion#11165paritytech-processbot[bot] merged 1 commit intomasterfrom
paritytech-processbot[bot] merged 1 commit intomasterfrom
Conversation
davxy
added
B0-silent
wigy-opensource-developer
approved these changes
Apr 4, 2022
Contributor
wigy-opensource-developer
left a comment
wigy-opensource-developer
left a comment
There was a problem hiding this comment.
Quite surprising enum DigestItem is not dependent on the Config, but is under the sp_runtime::generic module. But this way no conversion is needed, indeed.
bkchr
approved these changes
Apr 4, 2022
Member
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
Bot
deleted the
davxy-remove-not-required-conversion
branch
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FRAME system
deposit_logtakes aDigestItem, i.e. exactly the type we are passing in