Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

relax input conditions of fixed::checked_from_integer#11159

Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom
kiz-relax-fixed-from
Apr 7, 2022
Merged

relax input conditions of fixed::checked_from_integer#11159
paritytech-processbot[bot] merged 2 commits intomasterfrom
kiz-relax-fixed-from

Conversation

@kianenigma
Copy link
Copy Markdown
Contributor

fixes #10572

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 4, 2022
Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good. Hopefully this won't affect any calls,
as the CI is currently indicating.

@kianenigma
Copy link
Copy Markdown
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot Bot merged commit e6ae0b0 into master Apr 7, 2022
@paritytech-processbot paritytech-processbot Bot deleted the kiz-relax-fixed-from branch April 7, 2022 07:46
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* relax input conditions of fixed::checked_from_integer

* Fix build
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* relax input conditions of fixed::checked_from_integer

* Fix build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

from_{integer} for FixedPointNumbers

3 participants