This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Prep to release sp-version-proc-macro with codec 3 #10972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion to take this change
jsdw
added
B0-silent
ascjones
approved these changes
Mar 3, 2022
lexnv
approved these changes
Mar 3, 2022
Contributor
Author
|
As with #10937 I'm assuming we can ignore the check-dependent-polkadot failure? @kianenigma you merged #10937; are you happy to merge this also? :) |
Contributor
Author
|
I've realised that we don't need |
Contributor
|
Still, it could be a problem for anyone else using |
Contributor
Author
|
We've decided to just yank the latest sp-version that we released (with the dupe codec dependency issue) and pretend it didn't happen, since we don't need it for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed when releasing other crates for subxt using parity-scale-codec 3.0.0 (see #10937), so we patch bump sp-version so that things "just work" (given that 5.0.0 was released with the intention of having this change) and major bump sp-version-proc-macro which already has the codec 3.0.0 update we want in.