Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Don't create DB leaves when syncing historic blocks #10844

Merged
arkpar merged 3 commits into from
Feb 11, 2022
Merged

Don't create DB leaves when syncing historic blocks #10844

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c82836f
Don't create DB leaves when syncing historic blocks
arkpar Feb 11, 2022
2078100
Changed leaves check and added test
arkpar Feb 11, 2022
f47578c
fmt
arkpar Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/db/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,7 +1472,8 @@ impl<Block: BlockT> Backend<Block> {
}

if !existing_header {
{
// Add a new leaf if the block is outside the block gap.
if block_gap.map_or(true, |(start, _)| number != start) {

@cheme cheme Feb 11, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be number < start || number > end?

@bkchr bkchr Feb 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or can we not just directly check that number > last_finalized_state?

let mut leaves = self.blockchain.leaves.write();
leaves.import(hash, number, parent_hash);
leaves.prepare_transaction(
Expand Down