Apply `WeightToFeePolynomial`s to `pallet_transaction_payment`'s length fee #10785

notlesh · 2022-02-02T21:29:45Z

This PR is one potential way to address #10784. It adds the same WeightToFeePolynomial mechanics used for weight fees in pallet_transaction_payment to length fee. The main goal is to provide more flexibility in charging for transaction size; see the issue for more info on the motivation.

This PR would need substantial work, and would probably introduce breaking changes wherever the pallet's config is used.

polkadot companion: paritytech/polkadot#5028
cumulus companion: paritytech/cumulus#1152

frame/transaction-payment/src/lib.rs

shawntabrizi · 2022-02-03T14:17:45Z

seems like a fine change to me

notlesh · 2022-03-03T21:13:05Z

frame/transaction-payment/src/lib.rs

 	}

+	fn length_to_fee(length: u32) -> BalanceOf<T> {
+		T::LengthToFee::calc(&(length as u64)) // TODO: saturating / upper bound


I had left this TODO here because fn weight_to_fee below provides an upper bound.

While I'm not quite sure why it's needed in weight_to_fee, it's guaranteed to be no larger than u32::MAX in the case of length_to_fee, which is likely much smaller than max_block.

Another pair of eyes would be great though.

frame/support/src/weights.rs

frame/transaction-payment/src/lib.rs

notlesh · 2022-03-29T13:37:10Z

Any update on this, esp. @kianenigma ?

frame/support/src/weights.rs

frame/transaction-payment/src/lib.rs

crystalin · 2022-04-06T15:46:17Z

Any update on the reviews :) ? (also CI is not running)

kianenigma · 2022-04-06T16:04:54Z

some warnings seem legit, CI will run now.

notlesh · 2022-04-06T19:29:37Z

I'm guessing my polkadot companion PR has CI blocked as well:

paritytech/polkadot#5028

notlesh · 2022-04-06T20:39:13Z

My companion polkadot PR is building locally for me. If I'm reading CONTRIBUTING.adoc correctly, I think its CI is expected to be failing at this point. Let me know if I can do anything else to push this along.

notlesh · 2022-04-07T02:18:53Z

I added a cumulus companion PR: paritytech/cumulus#1152

It may need CI enabled for me.
Also, I think it and my polkadot companion (paritytech/polkadot#5028) need labels added.

Thanks :)

kianenigma · 2022-04-07T11:24:47Z

bot merge

…th fee (paritytech#10785) * Apply WeightToFeePolynomials to length fee * Remove TransactionByteFee * Add test cases for ConstantModifierFee * Restore import * Use pallet::constant_name * Remove irrelevant TODO comment * Update frame/support/src/weights.rs * Update frame/transaction-payment/src/lib.rs * Update frame/transaction-payment/src/lib.rs * Update frame/transaction-payment/src/lib.rs Co-authored-by: Kian Paimani <[email protected]> * s/ConstantModifierFee/ConstantMultiplier/ * Impl LengthToFee for test configs * fmt * Remove unused import * Impl WeightToFeePolynomial for byte fee in ExtBuilder * Remove unused import * fix doc Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]>

Apply WeightToFeePolynomials to length fee

bca17ee

notlesh mentioned this pull request Feb 2, 2022

pallet_transaction_payment's TransactionByteFee is completely inflexible #10784

Closed

ggwpez added the A3-in_progress Pull request is in progress. No review needed at this stage. label Feb 3, 2022

shawntabrizi reviewed Feb 3, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

notlesh mentioned this pull request Feb 9, 2022

Tweak Substrate-based fees moonbeam-foundation/moonbeam#1218

Closed

notlesh added 5 commits February 24, 2022 13:44

Remove TransactionByteFee

5276cd7

Add test cases for ConstantModifierFee

fc7486b

Merge branch 'master' into notlesh-apply-polynomials-to-length-fee

f436013

Restore import

829f286

Use pallet::constant_name

2dd3822

notlesh commented Mar 3, 2022

View reviewed changes

Remove irrelevant TODO comment

d14ccf3

notlesh mentioned this pull request Mar 3, 2022

Replace TransactionByteFee with LengthToFee paritytech/polkadot#5028

Merged

notlesh marked this pull request as ready for review March 3, 2022 21:50

shawntabrizi approved these changes Mar 3, 2022

View reviewed changes

bkchr approved these changes Mar 4, 2022

View reviewed changes

frame/support/src/weights.rs Outdated Show resolved Hide resolved

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

bkchr added 3 commits March 4, 2022 12:23

Update frame/support/src/weights.rs

11c138d

Update frame/transaction-payment/src/lib.rs

0ed5de4

Update frame/transaction-payment/src/lib.rs

34c6545

bkchr requested a review from kianenigma March 4, 2022 11:23

notlesh mentioned this pull request Mar 16, 2022

Utilize LengthToFee feature moonbeam-foundation/moonbeam#1353

Closed

kianenigma reviewed Mar 31, 2022

View reviewed changes

frame/support/src/weights.rs Outdated Show resolved Hide resolved

kianenigma reviewed Mar 31, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Show resolved Hide resolved

kianenigma reviewed Mar 31, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

kianenigma approved these changes Mar 31, 2022

View reviewed changes

kianenigma added A8-mergeoncegreen and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 31, 2022

Merge branch 'master' into notlesh-apply-polynomials-to-length-fee

41d9935

notlesh and others added 6 commits April 6, 2022 17:15

Impl LengthToFee for test configs

bef9e21

Merge branch 'master' into pr/10785

e110df7

fmt

e8a1b3a

Remove unused import

5a9b0c5

Impl WeightToFeePolynomial for byte fee in ExtBuilder

51ee1c2

Remove unused import

e3c37fb

fix doc

855fc05

notlesh mentioned this pull request Apr 7, 2022

Add LengthToFee to runtimes paritytech/cumulus#1152

Merged

paritytech-processbot bot merged commit a1497f5 into paritytech:master Apr 7, 2022

nazar-pc mentioned this pull request Apr 15, 2022

More efficient identity and multiplier weight to fee #11226

Merged

github-actions bot mentioned this pull request Apr 20, 2022

Update substrate/polkadot/cumulus from v0.9.18 to v0.9.19 moonbeam-foundation/moonbeam#1428

Closed

jasl mentioned this pull request Apr 21, 2022

Upgrade to polkadot-v0.9.19 Phala-Network/khala-parachain#96

Merged

2 tasks

wischli mentioned this pull request Apr 27, 2022

feat: upgrade to Polkadot v0.9.19 KILTprotocol/kilt-node#357

Merged

8 tasks

ghzlatarev mentioned this pull request May 4, 2022

Adjust congested_chain_simulation test when we integrate account for the length component of the transaction fee Manta-Network/Manta#530

Closed

sander2 mentioned this pull request May 10, 2022

chore: upgrade to polkadot 0.9.19 interlay/interbtc#593

Merged

ghzlatarev mentioned this pull request May 11, 2022

Multiply tx len and base fee component by max number of remarks per block, in the fees calculation of congested_chain_simulation test Manta-Network/Manta#536

Merged

10 tasks

notlesh mentioned this pull request May 12, 2022

Introduce exponential length fee for substrate-based fees moonbeam-foundation/moonbeam#1496

Merged

Dengjianping mentioned this pull request Jul 7, 2022

Bump deps to v0.9.22 Manta-Network/Manta#571

Merged

10 tasks

github-actions bot mentioned this pull request Jul 18, 2022

Update substrate/polkadot/cumulus from v0.9.18 to v0.9.19 imstar15/moonbeam#1

Open

ghzlatarev mentioned this pull request Jul 29, 2022

Update deps from v0.9.22 to v0.9.26 Manta-Network/Manta#720

Merged

3 tasks

Apply WeightToFeePolynomials to pallet_transaction_payment's length fee #10785

Apply WeightToFeePolynomials to pallet_transaction_payment's length fee #10785

Uh oh!

Conversation

notlesh commented Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shawntabrizi commented Feb 3, 2022

Uh oh!

notlesh Mar 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

notlesh commented Mar 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crystalin commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kianenigma commented Apr 6, 2022

Uh oh!

notlesh commented Apr 6, 2022

Uh oh!

notlesh commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

notlesh commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kianenigma commented Apr 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Apply `WeightToFeePolynomial`s to `pallet_transaction_payment`'s length fee #10785

Apply `WeightToFeePolynomial`s to `pallet_transaction_payment`'s length fee #10785

notlesh commented Feb 2, 2022 •

edited

Loading

notlesh Mar 3, 2022 •

edited

Loading

crystalin commented Apr 6, 2022 •

edited

Loading

notlesh commented Apr 6, 2022 •

edited

Loading

notlesh commented Apr 7, 2022 •

edited

Loading