This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Change intial best beefy block #10669
Closed
Wizdave97
wants to merge
15
commits into
paritytech:master
from
Wizdave97:david/runtime-api-for-session-boundary
Closed
Change intial best beefy block #10669
Wizdave97
wants to merge
15
commits into
paritytech:master
from
Wizdave97:david/runtime-api-for-session-boundary
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… david/runtime-api-for-session-boundary
bkchr
suggested changes
Jan 17, 2022
… david/runtime-api-for-session-boundary
Contributor
Author
|
The polkadot companion has been fixed, the CI checks need to be restarted |
… david/runtime-api-for-session-boundary
… david/runtime-api-for-session-boundary
… david/runtime-api-for-session-boundary
acatangiu
approved these changes
Jan 24, 2022
Contributor
acatangiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Contributor
|
@bkchr please take a look at this PR and its companion, thanks! |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
|
Bump |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
|
Alternative PR #10882 merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a runtime storage value in the session pallet that holds the block number of when session changes occur.
Fixes paritytech/grandpa-bridge-gadget#256 when done
polkadot companion: paritytech/polkadot#4729