This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Improve BoundedVec API (extracted from #10195)#10656
Merged
Conversation
shawntabrizi
added
B0-silent
shawntabrizi
added
D9-needsaudit 👮
13 tasks
KiChjang
reviewed
Jan 14, 2022
KiChjang
reviewed
Jan 14, 2022
| return true | ||
| } | ||
|
|
||
| debug_assert!(false, "all noop conditions should have been covered above"); |
Contributor
There was a problem hiding this comment.
Wonder if we can try fuzzing this function to ensure that this assertion is never hit.
Member
There was a problem hiding this comment.
no need to fuzz it; you can just prove it logically.
KiChjang
reviewed
Jan 14, 2022
KiChjang
approved these changes
Jan 14, 2022
Contributor
KiChjang
left a comment
KiChjang
left a comment
There was a problem hiding this comment.
Don't see major issues; I think it does need an audit though.
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
gavofyork
approved these changes
Jan 17, 2022
jakoblell
added
D1-audited 👍
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…10656) * Gav wrote this code in pull paritytech#10195. Extracting to simplify that PR. * fix potential panics * prevent panics in slide * update doc * fmt * Update frame/support/src/storage/bounded_vec.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Gav Wood <gavin@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…10656) * Gav wrote this code in pull paritytech#10195. Extracting to simplify that PR. * fix potential panics * prevent panics in slide * update doc * fmt * Update frame/support/src/storage/bounded_vec.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Gav Wood <gavin@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
BoundedVecAPI, porting some existing features of the standardVecand adding some new features such asforce_push,slide, etc... (see code for details)Trying to simplify the diff in #10195, original author is @gavofyork