This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Generate storage info for Pallets Offences and Session#10113
Closed
georgesdib wants to merge 94 commits intoparitytech:masterfrom
georgesdib:offences-storage-info
Closed
Generate storage info for Pallets Offences and Session#10113georgesdib wants to merge 94 commits intoparitytech:masterfrom georgesdib:offences-storage-info
georgesdib wants to merge 94 commits intoparitytech:masterfrom
georgesdib:offences-storage-info
Conversation
added 30 commits
September 20, 2021 22:11
to pallet staking. Moved MAX_UNLOCKING_CHUNKS from being a constant to being a type called `MaxUnlockingChunks`
`MaxNominations` to allow it to be a bound for a `BoundedVec`
pallet compiles!
storage to being a runtime parameter `MaxNbOfValidators` Fixing various other compile errors
… staking-storage-info
implementation to `frame-support`
This was referenced Oct 28, 2021
Companion for Generate storage info for Pallets Offences and Session #10113
paritytech/polkadot#4174
Closed
added 3 commits
October 30, 2021 18:17
in session pallet. This is done so that it's less restrictive on cumulus when using `SessionManager` Moving implementation of `map_collect` to `WeakBoundedVec` Adding tests for `map_collect` and `map_collect_ref`
…/substrate into offences-storage-info
georgesdib
requested review from
adoerr,
andresilva and
kianenigma
as code owners
kianenigma
reviewed
Oct 31, 2021
added 9 commits
November 1, 2021 21:33
… offences-storage-info
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of paritytech/polkadot-sdk#323.
Adding
generate_storage_infoto palletsoffencesandsession.This PR depends on #9864 being merged first.
Polkadot companion: paritytech/polkadot#4174.
Cumulus companion: paritytech/cumulus#710.
Summary of changes below:
Changing
MAXIMUM_TARGETSconstant into a runtime paramMaxTargets.Updated
election-provider-supportdocumentation accordingly.Adding
generate_storage_infoto palletsoffencesandsessionwith the corresponding changes and test changes.I had to introduce
MaxKeysEncodingSizeto bound the encoding of the keys.Adding
map_collectandmap_collect_refutility functions toWeakBoundedVec, this allows to write shorter code when manipulatingBoundedVec. I have also added tests for these 2 functions.Moved traits
ReportOffenceandOnOffenceHandleras well as the structOffenceDetailsfromprimitives/stakingintoframe-supportto be able to useWeakBoundedVec.