-
Notifications
You must be signed in to change notification settings - Fork 2.6k
try-runtime-cli
panics on Polkadot
#14006
Comments
It is doing 94 recursions of |
Seems like some of the parallelization added in #12537 is causing more issues than helping :( |
Yea not sure how much it helped with the speed, came up in the review here #13923 (comment) But the panic is not from your parallel change, but rather also #13923. We should add a test that it does not break in Polkadot 😅 |
Hey thanks for raising this. I had been testing try-runtime against a local Polkadot node on my laptop without any issues, I wasn't aware a CI env existed that needs testing against. I'm looking into this now. |
Try creating a new client in the "batch thread" instead of cloning should fix that... Here
|
... until paritytech/substrate#14006 is done. Signed-off-by: Oliver Tale-Yazdi <[email protected]>
* Companion for substrate * Adds kusama migration * update lockfile for {"substrate"} * Temp allow try-runtime to fail ... until paritytech/substrate#14006 is done. Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: parity-processbot <> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Yea this still fails, so i cant test #13417 |
The same error after #14030? Then we need what I wrote in the PR |
Yea looks like the same error BT
Now after a re-run it does work. so probably something flaky… |
Thanks for the logs. I'm going to prioritise refactoring this to remove the redundant multi-threading, which should resolve this issue. |
It also happens with |
No, the problem is that the runtime that created client is closed when the background task tries to perform the RPC call ^^ The number of threads shouldn't matter |
* Companion for substrate * Adds kusama migration * update lockfile for {"substrate"} * Temp allow try-runtime to fail ... until paritytech/substrate#14006 is done. Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: parity-processbot <> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
On commit Polkadot 3595684b0293439c32dfe563008958c7d0091289 ran:
Truncated output:
Need this for testing a change. Full log from the CI.
The text was updated successfully, but these errors were encountered: