Create Modal for Brave Browser notification

[wirednkod]

This PR creates the notification inside Popup and Options (only in Brave Browser) about the socket restriction that was introduced in Brave Browser in version 1.36.109.

Final design details are still pending.
Fixes #1178

A new PR will open to adjust the design when it is provided.

Popup outcome:

Options outcome:

[wirednkod]

Some extra info: Dismiss button is adding an entry in localStorage for the note to stop appearing.
Learn more should lead to Landing Page section that will explain what happened with Brave Browser

[tomaka]

I'm not a fan of using localStorage directly from within UI components. This is spaghetti-ish. But I don't want to go back and forth with review comments.

[wirednkod]

I'm not a fan of using localStorage directly from within UI components. This is spaghetti-ish. But I don't want to go back and forth with review comments.

I see what you mean - will transfer it to the background. Thank you

[tomaka]

Your last commit is actually IMO worse than what there was before.
The problem of "using localStorage directly" has nothing to do with using localStorage directly, it has to do with using localStorage.
The code of the UI component shouldn't contain any reference to the word "local storage". It should query the state of this modal popup, and it's background.ts that decides that this state is stored in the local storage.

[wirednkod]

Your last commit is actually IMO worse than what there was before. The problem of "using localStorage directly" has nothing to do with using localStorage directly, it has to do with using localStorage. The code of the UI component shouldn't contain any reference to the word "local storage". It should query the state of this modal popup, and it's background.ts that decides that this state is stored in the local storage.

The wording in your comment, sounded like the UI components should not access chrome.storage at all, rather than "querying" the state of this modal popup, and it's 'background.ts' that decides that this state is stored in the local storage. Comment above makes clearer what you actually meant. Will alter in a new PR