-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substrate Connect Browser Source Map Warnings #1196
Comments
Thank you @rossbulat .This is mentioned as |
I have to correct that - the issue appears in the |
Great work discovering the issue! Removing the Source maps is what I'd lean towards purely as an optimisation. It is also questionable whether devs will want to debug this over assuming we are shipping correct code or just to post an issue if bugs are found. |
I think for now I should leave the |
@wirednkod @rossbulat @tomaka |
Thank you @sesh92 . Can you please help me understand why this did not work? I am running the deployed and local versions of polkadot dashboard and I do not receive the warnings mentioned in the description. |
@wirednkod I've built a local project with the latest
while build the project I've got the warnings |
Can you please create a repo with that code for further investigation? I mean the issue for us was that the separated source map files were not discoverable by the build, and making them inline seemed to solve the issue. I have also a test repo with minimum
|
@wirednkod I've created the repo https://github.com/sesh92/warnings |
|
As per @wirednkod, here are some warnings being displayed when running a project with substrate connect.
This may be because of a CRA / webpack 5 issue noted here: https://stackoverflow.com/a/70834076
And being discussed here: facebook/create-react-app#11752
GENERATE_SOURCEMAP=false
would remove these warnings, are there any practicalities of having these source maps in production?Referencing polkadot-cloud/polkadot-staking-dashboard#166
The text was updated successfully, but these errors were encountered: