Implement transaction/{ , material, fee-estimate}
#246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update readme save save update middleware update openapi update readme update readme readme
danforbes
approved these changes
Aug 31, 2020
Contributor
danforbes
left a comment
danforbes
left a comment
There was a problem hiding this comment.
Looks very good...just some documentation questions/nitpicks. In general, I'm curious where we want to draw the line with transaction v. extrinsic.
emostov
commented
Sep 1, 2020
Contributor
Author
emostov
left a comment
emostov
left a comment
There was a problem hiding this comment.
I'm curious where we want to draw the line with transaction v. extrinsic.
@danforbes agreed - rereading it is actually pretty confusing if I am to put myself in the shoes of someone new to substrate. I think we need to choose just one because right now the chooses in this PR seem semi arbitrary.
joepetrowski
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
/transaction/transaction/materialtransaction/fee-estimateAdditionally this updates
openapi-proposal.yamlto reflect the endpoint implementation.