-
Notifications
You must be signed in to change notification settings - Fork 162
Add OpenApi UI structure in docs folder for future use #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Small update Update
add docs:build to package.json Small updates Update gitignore Update update eslintignore update author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you testing this? I don't know much about hosting stuff like this through GitHub Pages. My first inclination was to pull the branch down locally and try to access the UI that way but I realized that's not how things are set up.
|
@danforbes You should be able to pull the branch down and test it that way. Its in Also you can access the version from this branch here: https://paritytech.github.io/substrate-api-sidecar/dist/ |
danforbes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the directory structure and everything looks fine. I would suggest maybe adding a better README to the docs folder to explain where the actual OpenAPI spec is and what the other folders are for. Anything else in particular you were curious about?
dvdplm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all calls have error descriptions – does that mean they can't fail? In general this lgtm a part from a few nits.
In theory we only have to detail all known errors. So essentially all 4xx errors should be detailed and some 5xx that are hard coded. I actually have not gone through the code and the specs though to make sure they align. I mostly just have errors from middleware that apply broadly. If we want to be thorough this definitely needs to be looked at carefully. |
save temp save changes to temp save save
| authId: oauth2.auth.name, | ||
| source: "auth", | ||
| level: "warning", | ||
| message: "Authorization may be unsafe, passed state was changed in server Passed state wasn't returned from auth server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusing
It's ok to defer this to a separate PR. Can you file a ticket? |
dvdplm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: David <[email protected]>
This PR adds an OpenApi UI that will be hosted by github pages. The plans for v1.0.0 release are reflected in
openapi-v1.yaml, while the plans for routes to add in v1.1.0 are reflected inopenapi-v1-todo.yaml. The UI is currently set to show the v1.0.0 paths, which arenot yetfully implemented.Relates to #227