Implement node endpoints #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test node transaction pool Test node version Add return types for services
Collaborator
joepetrowski
left a comment
joepetrowski
left a comment
There was a problem hiding this comment.
I'm not sure if we need to get the latest block and metadata, except maybe for tx pool to decode calls. Could use docs on what is being returned.
danforbes
approved these changes
Aug 21, 2020
Contributor
danforbes
left a comment
danforbes
left a comment
There was a problem hiding this comment.
Mostly nitpicks...this will be a great addition 🚗
Comment on lines
11
to
13
| * - `clientImplVersion` Node's implementation's version. | ||
| * - `clientImplName` Node's implementation name. | ||
| * - `chain` Chain's spec name. |
Contributor
There was a problem hiding this comment.
Make these a little jazzier.
joepetrowski
approved these changes
Aug 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #225
Closes #168
Closes #220
Overview
This PR implements the node endpoints as specified in the
openapi-proposal.yaml. This includesnode/version,node/transaction-pool, andnode/network.For each, the code lightly wraps RPC calls. For
system_peers, it was found that Parity public nodes do not support the RPC call, so it was wrapped in a try/catch block, and puts in a message if the RPC method does not work.Bare bones unit tests are implemented to have some degree of a user contract that can be used to show regressions. So far though I have not been able to fully test
node/transaction-poolas there has been no pending extrinsic.Follow up PRs