This repository was archived by the owner on Nov 4, 2024. It is now read-only.
add to sccache features redis#91
Merged
Merged
Conversation
TriplEight
reviewed
Aug 15, 2019
Contributor
TriplEight
left a comment
TriplEight
left a comment
There was a problem hiding this comment.
I think now it's your turn to review this.
gabreal
approved these changes
Aug 15, 2019
Contributor
gabreal
left a comment
gabreal
left a comment
There was a problem hiding this comment.
looks good - just curious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the images which are used in parity-ethereum build process are now being published to our Gitilab docker container registry.
These images now are making use of
sccachewith Redis to avoid the data race condition when pruning old cache pieces.Metadata was also edited to show the current addresses of the images.