Introduce polkadot-musl-builder #352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriplEight
approved these changes
Feb 9, 2022
|
Even that it's stale and really outdated, IMO this contribution is important, I'll keep it open to be picked up by someone maybe sometime in the future. cc @paritytech/release-engineering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I will not able to follow up on the reviews for this PR because I'm going on vacation. I put this together before leaving in hopes it'll be easier for someone else to take over this work.
Additionally https://github.com/joao-paulo-parity/polkadot/blob/musl/Dockerfile is the link of where the script was ported from in case something got lost in translation.
Note: As documented in the script, I'm defaulting
POLKADOT_BRANCHtov0.9.9-1because lots of jemalloc undefined symbol errors appeared after the switch tikv-jemallocator fork (paritytech/polkadot#3897). Good news is that it's a single error which only happens during the very last step, when it's assembling the binary, and apparently does not seem to be difficult to solve - it might require an upstream PR on https://github.com/tikv/jemallocator though.related to https://github.com/paritytech/release-engineering/issues/193