Revert bitvec field order to maintain binary compatiblilty#143
Merged
wigy-opensource-developer merged 2 commits intomasterfrom Feb 24, 2022
Merged
Revert bitvec field order to maintain binary compatiblilty#143wigy-opensource-developer merged 2 commits intomasterfrom
wigy-opensource-developer merged 2 commits intomasterfrom
Conversation
wigy-opensource-developer
approved these changes
Feb 24, 2022
bkchr
approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #137 which updates bitvec to
1.0the order of the type params changes, but the order of the fields is also changed (unnecessarily) and it breaks binary compatibility with polkadot.js https://github.com/polkadot-js/api/blob/ed2f512cfc2481de8fd2e895038ebdd603a9e1c5/packages/types/src/metadata/PortableRegistry/PortableRegistry.ts#L518.This PR restores the fields to their original order.