Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotating a type with
#[scale_info(capture_docs = "always|never|default")]will override the default docs capturing enabled by thedocsfeature.#[scale_info(capture_docs = "never")]Never capture docs for a specific type even if the
docsfeature is enabled.#[scale_info(capture_docs = "always")]Always capture docs for a specific type even if the
docsfeature is not enabled.#[scale_info(capture_docs = "default")]Captures docs iff the
docsfeature is enabled, which is the default if this attribute is not presentThis will allow e.g. including required docs for enums such as
Call,Erroretc in substrate pallets without adding docs for every single other type, thus bloating the runtime size.Derive refactoring
Much of the changes in the diff are because of the
TypeInfoImpltype I have introduced into the derive implementation, which allows sharing of the attributes and other state to avoid it having to be passed around through all the methods. We could do some further refactoring here but this is a good first step.