Make variant index explicit, remove discriminant#112
Merged
Conversation
10 tasks
Robbepop
approved these changes
Jul 15, 2021
Contributor
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
I agree we should not put Rust specifics into this format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback from @jacogr.
Explicitly specify enum variant index. Prevents consumers having to duplicate the logic of inferring missing indices by the position in the list of variants.
Also removes
discriminant, it was actually populated with the same value asindexwould be anyway. It's a legacy of when this was aiming to be general purpose Rust static reflection lib. Now we are a SCALE specific lib we should remove this Rust specific concept.