Skip to content

Conversation

@0xf333
Copy link
Contributor

@0xf333 0xf333 commented Nov 3, 2025

@xermicus

this is to address issue #379

implementation test

cargo test -p resolc ipfs
cargo test -p revive-solc-json-interface ipfs

addressing issue#379

implementation test
-------------------
cargo test -p resolc ipfs
cargo test -p revive-solc-json-interface ipfs

Signed-off-by: 0xf333 <[email protected]>
@kvpanch kvpanch requested a review from xermicus November 4, 2025 12:32
Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, many thanks for the PR!

The end goal (to make this useful first hand) is to append it as CBOR data to the bytecode.

See also the solc documentation:
https://docs.soliditylang.org/en/latest/metadata.html#encoding-of-the-metadata-hash-in-the-bytecode
https://docs.soliditylang.org/en/latest/060-breaking-changes.html#metadata-hash-options

Sorry it doesn't say it in the issue. I added a few sentences to the issue.

@xermicus
Copy link
Member

@0xf333 After some more consideration, we might actually store the metadata hash not in the bytecode but in pallet revive. This will simplify the PR here a lot (the PR would be a lot closer to be ready). Please hold your horses. I'll let you know once a decision is made.

@0xf333
Copy link
Contributor Author

0xf333 commented Nov 28, 2025

@0xf333 After some more consideration, we might actually store the metadata hash not in the bytecode but in pallet revive. This will simplify the PR here a lot (the PR would be a lot closer to be ready). Please hold your horses. I'll let you know once a decision is made.

@xermicus
Alright, keep me posted. I should have time to jump back to this by next week. Been busy with some infra stuff, sorry for the late reply.
Let's just make sure that it's next week, not the week after that. Let me know, the ball is in your court

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants