Validate that rules can not repeat names #32
Comments
Bullrich
added a commit
that referenced
this issue
Aug 1, 2023
Resolves #6 ## Changes - Fixed validation of rules not setting default values. - Fixed basic rule amount of review to be a positive integer (min value 1) - Added a test to verify this - Implemented GitHub Action to run on Pull Requests. - Added a log which reports what teams and users are missing. - Fixed a bug where the approvals wasn’t being properly filtered. - Fixed a bug where the system asked the author to review the PR - Fixed the wrong default name of the config file - Was set to `review.yml` instead of `review-bot.yml` - Changed rule type validation to have forced string values. - Added logs which inform when a rule is running and if it fails. - Rules are executed in order, so the logs will always correspond to the current rule. - Created tickets #32, #33 and #34 as foreseeable problems. - Created utility method to concatenate two arrays and removing duplicates. - @mutantcornholio I don’t know if `EngAutomation/js` has this (or if we want to add it to it) - Fixed a bug where the users who had approved the PR was not caching. - Fixed a glitch where the required reviews could be 0 or a negative number. - Fixed a glitch where the rule type could be invalid.
Bullrich
added a commit
that referenced
this issue
Aug 8, 2023
Bullrich
added a commit
that referenced
this issue
Aug 8, 2023
Bullrich
added a commit
that referenced
this issue
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the sake of logging, let’s make sure that two rules can not repeat the name.
The text was updated successfully, but these errors were encountered: