This repository was archived by the owner on Apr 2, 2020. It is now read-only.
Use network specific critical flag#14
Merged
Merged
Conversation
tomusdrw
reviewed
Jun 6, 2018
Contributor
There was a problem hiding this comment.
Looks good in general. Maybe it would be better to temporarily support both formats (i.e. first check network-specific, later meta if not defined).
I think it would make it easier to handle the transition period.
Also could we get tests for both cases?
ascjones
force-pushed
the
aj-network-specific-critical-flag
branch
from
4f12dfc to
f78ec84
Compare
tomusdrw
approved these changes
Jun 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rel openethereum/parity-ethereum#8821.
Allows specifying whether a given release is critical per network.