Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Fix starting line count#85

Merged
joao-paulo-parity merged 1 commit intoparitytech:masterfrom
joao-paulo-parity:fix
Apr 14, 2022
Merged

Fix starting line count#85
joao-paulo-parity merged 1 commit intoparitytech:masterfrom
joao-paulo-parity:fix

Conversation

@joao-paulo-parity
Copy link
Contributor

githubLogsInitialLineCount became outdated when I moved the tokens from inputs to action configuration in #74. This results in unpleasant UX since because the offset is bigger than it should be GitHub doesn't scroll to the right line, thus forcing users to scroll all the way down to the bottom of the logs manually.

@joao-paulo-parity joao-paulo-parity requested a review from a team as a code owner April 14, 2022 15:42
@joao-paulo-parity joao-paulo-parity merged commit 7f1dd98 into paritytech:master Apr 14, 2022
@joao-paulo-parity joao-paulo-parity deleted the fix branch April 14, 2022 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants