Handle Rust >= 1.91 change of target-pointer-width JSON type#341
Handle Rust >= 1.91 change of target-pointer-width JSON type#341cmichi wants to merge 1 commit intoparitytech:masterfrom
target-pointer-width JSON type#341Conversation
|
Sigh.... they made such silly breaking change?! Seriously? Thank you for the PR, I had no idea they broke this. However, I really don't want to bump the MSRV, especially to a version that is going to just be released. Not everyone updates their compiler immediately, and not everyone even can update it. We still want to be able to push new PolkaVM versions to older, stable branches, which might still use an older compiler, so bumping it to a bleeding-edge version of rustc isn't really an acceptable solution. I've only just bumped the MSRV to 1.86.0 two months ago (being forced to do it by Rust analyzer stopping support, and by the lack of stable SIMD; otherwise I was perfectly happy with staying on 1.75 forever), and I'm not planning to bump it again probably for another half a year at least. So we'll need to find another solution that will work on both old and new versions of rustc. |
For |
|
Yeah, we'll have to do something similar. I already do version detection in picosimd (which is needed for my new gas cost model implementation), so we'll do something like that. |
|
Should be fixed now with #347 |
2 participants
With the upcoming Rust 1.91, linking with
polkavmwill fail due to:This can already be observed in Rust nightly.
The error occurs because of rust-lang/rust#144443, which changes the
target-pointer-widthtype.This PR raises the MSRV throughout and accounts for this type change. I've raised the MSRV of
tools/{benchtool,gastool}as well, as those use thepolkavmlinker too.The CI will fail for now, but once Rust 1.91 is published (October 30, 2025) it will succeed. I'm already creating the PR now to surface that this is the cause of failure to link in nightly.