This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Companion PR to #5182 - Substrate offchain signing#985
Merged
tomusdrw merged 22 commits intoparitytech:masterfrom Apr 21, 2020
Merged
Companion PR to #5182 - Substrate offchain signing#985tomusdrw merged 22 commits intoparitytech:masterfrom
tomusdrw merged 22 commits intoparitytech:masterfrom
Conversation
rakanalh
added
the
A3-in_progress
4 tasks
gavofyork
added
the
A4-companion
rphmeier
approved these changes
Apr 15, 2020
added 8 commits
April 20, 2020 17:41
rakanalh
changed the title
tomusdrw
approved these changes
Apr 21, 2020
tomusdrw
removed
the
A3-in_progress
rphmeier
reviewed
Apr 21, 2020
| use crate::attestations::{self, IncludedBlocks}; | ||
| use crate::registrar::Registrar; | ||
|
|
||
| pub const KEY_TYPE: KeyTypeId = KeyTypeId(*b"para"); |
Contributor
There was a problem hiding this comment.
@rakanalh Please follow up - there are missing docs here and below. Also, this is probably duplicated from primitives/src/parachain. Why not define this for ValidatorId or the fish key?
Contributor
Author
There was a problem hiding this comment.
I originally wanted to do this but somehow forgot to. Will follow up in a new PR.
rphmeier
reviewed
Apr 21, 2020
runtime/common/src/parachains.rs
Outdated
| } else { | ||
| None | ||
| } | ||
| Signer::<T, T::AuthorityId>::any_account() |
Contributor
There was a problem hiding this comment.
cc @montekki Did we want this to be the fish key instead?
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#5182