-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
| authoring_version: 2, | ||
| spec_version: 1054, | ||
| impl_version: 0, | ||
| impl_version: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem like anything changed in runtime behavior from substrate side, but would appreciate that someone double checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have this carefully reviewed. If there is a new runtime (wasm blob) with new functions and it does not have a new spec_version id there will be quite a bit of impact in the ecosystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocks would fail to import with the native runtime, the node would print out an error like invalid state root and then the block would still be imported using wasm runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah no problem to bump the impl_version as long as we are absolutely certain that the runtime functions and metadata descriptions have not changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to diminish your comment either, I appreciate your heads up :) We already deployed this PR on some of our nodes an hour ago to test the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually great that this sort of stuff pops-up in your CI-pipeline :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything fine: paritytech/substrate@d383b0d...68e51d6
* bump version to v0.7.27 * update to latest substrate polkadot-master * bump runtime impl_version
No description provided.