Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@andresilva
Copy link
Contributor

No description provided.

@andresilva andresilva added the A0-please_review Pull request needs code review. label Mar 19, 2020
authoring_version: 2,
spec_version: 1054,
impl_version: 0,
impl_version: 1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like anything changed in runtime behavior from substrate side, but would appreciate that someone double checked.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have this carefully reviewed. If there is a new runtime (wasm blob) with new functions and it does not have a new spec_version id there will be quite a bit of impact in the ecosystem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocks would fail to import with the native runtime, the node would print out an error like invalid state root and then the block would still be imported using wasm runtime.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah no problem to bump the impl_version as long as we are absolutely certain that the runtime functions and metadata descriptions have not changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to diminish your comment either, I appreciate your heads up :) We already deployed this PR on some of our nodes an hour ago to test the release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually great that this sort of stuff pops-up in your CI-pipeline :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresilva andresilva requested a review from bkchr March 19, 2020 14:54
@andresilva andresilva merged commit a66eac2 into master Mar 19, 2020
@andresilva andresilva deleted the andre/release-0.7.27 branch March 19, 2020 16:24
General-Beck pushed a commit to General-Beck/polkadot that referenced this pull request Mar 19, 2020
* bump version to v0.7.27

* update to latest substrate polkadot-master

* bump runtime impl_version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants